Docs cleanup #14166
Merged
Docs cleanup #14166
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| <h3>Methods</h3> | ||
|
|
||
| <h4>$().alert()</h4> | ||
| <p>Wraps all alerts with close functionality. To have your alerts animate out when closed, make sure they have the <code>.fade</code> and <code>.in</code> class already applied to them.</p> | ||
| <p>Makes an alert listen for click events on descendant elements which have the <code>data-dismiss="alert"</code> attribute. (Not necessary when using the auto-initialization of the data-api.)</p> |
There was a problem hiding this comment.
@cvrebert Mind handing me the eloquence for one second here?
There was a problem hiding this comment.
"when using the data-api's auto-initialization" seems slightly better. Looks good overall.
|
Otherwise, LGTM 👍 |
|
Just getting started, thanks for the feedback. |
|
Wasn't done but I guess I can put the other changes in different PR. |
|
Oh, oops. 😁 The more PRs the better I suppose. I just want to move things along quickly because v4 is so much more interesting to work on right now lol. |
|
That's what I thought 😄 Had thought about splitting these changes up into separate PRs for each section for a while anyway. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
More to come. Posting already to get feedback on wording/certain changes.