fixes #13816 Modal dialog closes when dragging and releasing mouse button outside dialog

[fat]

Fixes #13816.

[fat]

@hnrch02 thoughts?

[hnrch02]

Oops 😁 I like it, seems like it breaks a lot of things though.

[hnrch02]

Including our dear friend backward compatibility.

[fat]

meh – the dom is slightly changed, but i think in a trivial way. not too worried about the backward compatibility of that – @mdo what do you think about the backwards compatibility here?

[hnrch02]

I agree, maybe we could emphasize this change in the release notes.

[fat]

cool - think i got the tests fixed 😅

[fat]

mark - this moves the backdrop element out of the body and into the modal element (it's how twitter does it)

[mdo]

I think we can get behind that. The backdrop was always programmatically inserted, so I don't think it makes too much of a difference for folks.

[FagnerMartinsBrack]

@fat

this moves the backdrop element out of the body and into the modal element

When a system updates page fragments through AJAX (simulating a page request, like senna) and the modal is open, then the backdrop will stay visible after the content have been replaced.

Moving the backdrop inside the modal fixes the issue.

@mdo

so I don't think it makes too much of a difference for folks.

It makes a difference in the case I mentioned above (in a good manner though).

[fat]

rad - gonna merge this then \o/

[Jim-Horn]

Hey guys, it looks like this commit broke the backdrop functionality for modals. I did a diff between 3.2.0 and 3.2.1 and tracked the issue to this commit. I just upgraded our webjars to use 3.3.2-1, and it's still broken. I've added the hack below to fix this locally. Any thoughts?

.modal-backdrop {
    position: fixed;
    bottom: 0;
}

[hnrch02]

@Jim-Horn This will be reverted by #15881.

[Jim-Horn]

Thanks Heinrich

Cheers, Jim