Fixes #14799: Add vertical alignment of image in media component

[jenndodd]

The .media-left and .media-right images can now be aligned vertically via the .media-middle and .media-bottom classes. Top is the default so we did not make an explicit .media-top class.

The .pull-right/left version still works and we left one example in the docs for testing purposes. Do you usually do that? We weren't sure how to make sure the deprecated version is still tested without keeping it in the docs.

Any thoughts? We'd love feedback.

@stubbornella, @jenndodd, & @bebepeng

Fixes #14799.

[hnrch02]

@jenndodd Would you mind removing the dist files from the PR? They're probably the reason for the merge conflicts.

[stubbornella]

We can do that, sure.

[stubbornella]

Hmm, just realized @jenndodd isn't in the office today, so we'll have to hold off until we can get her to push the fix.

[hnrch02]

Sure, no worries!

[gpleiss]

In giving our PR one more look over, we noticed that the media-object class appears not to affect appearance of the elements it is applied to. Is it possible to remove this class, or is it doing something else that we're not noticing?

[cvrebert]

All .media-object does is set display: block;:

bootstrap/less/media.less

Line 27 in 3bea2a4

display: block;

It doesn't do anything else and isn't used anywhere else in the Less code.

[gpleiss]

Even after reverting the dist changes we still got merge conflicts. So we modified the commits, rebased the latest changes to master, and force pushed the branch.

[hnrch02]

All .media-object does is set display: block;:

bootstrap/less/media.less

Line 27 in 3bea2a4

display: block;

It doesn't do anything else and isn't used anywhere else in the Less code.

Doesn't mean it can be removed though.

[mdo]

All .media-object does is insure a proper display for elements that might not be block level. It'll need to be there I believe.

[mdo]

Aside from the alignment for the legacy .media > .pull-left, none of this needs to be nested under .media. The .media, .media-right, .media-body, etc can all be top level selectors here to avoid unnecessary specificity.

[gpleiss]

Our bad! We're putting .media-object back, and we'll address the other issues @mdo brought up.

[mdo]

We're getting super close to a release here, so I took care of the problems here and merged to master. Thanks y'all!

[stubbornella]

Thanks! Sorry we were slow. Jenn was out of the office this week so we had to finagle some things to get new code to her fork.

Nicole

On Sat, Oct 25, 2014 at 9:47 PM, Mark Otto notifications@github.com
wrote:

We're getting super close to a release here, so I took care of the problems here and merged to master. Thanks y'all!

Reply to this email directly or view it on GitHub:
#14801 (comment)

[mdo]

No worries, yo! We're really trying to get v3.3 (formerly v3.2.1) out the door. This wouldn't have happened at all without @jenndodd and you, so thanks again to y'all and sorry if I rushed anyway 😁.

[hnrch02]

@mdo I think we missed the ship list entry for this one...

[cvrebert]

@hnrch02 Yeah, we should edit the GitHub Release description to mention it.

[hnrch02]

@cvrebert I'll do that.