Fixes to scope #15133
Fixes to scope #15133
Conversation
|
Can you split the |
|
Apparently, |
|
It used to be valid to use |
|
Splitting the |
|
Just split it as a separate patch for now and it should be OK. Thanks! |
as discssued in #15117 (comment) - added ``scope="row"`` to row headers - made sure row headers are actual ``<th>`` elements - removed ``scope="col"`` where it was redundant - simplified table examples with (to me) unnecessary ``rowspan``/``colspan`` (unless you really want complex tables, in which case we would need full-on ``id`` and ``headers`` attributes to make sure each table cell has an explicit association with the related header cells - overkill, in my opinion) - one table (in typography) left header-less, as it's more or less presentational (though its structure is still important, hence not adding ``role="presentation"``)
|
Travis seems to have gotten stuck on the
Is there any way to restart its test? |
|
Restarted the job. |
|
👍 |
|
on a separate note, this change (actually making the row headers Though then again, sometimes authors may want their first column to appear fatter to show something's a row header. Thoughts? |
|
/cc @mdo about ^^^ |
|
I'm okay with the first column being bold. No need for custom styles to override it. |
|
Thanks, y'all! |
As discussed in #15117 (comment)
scope="row"to row headers (can be either<td>or<th>, AT doesn't care much)scope="col"where it was redundantrowspan/colspan(unless you really want complex tables, in which case we would need full-onidandheadersattributes to make sure each table cell has an explicit association with the related headercells - overkill, in my opinion)