Fixes affix-top class not applying #15154
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use scrollTop instead of colliderTop which uses the elements offset().top, as the offset top does not account for padding. This issue can be replicated by using a navbar-fixed-top and applying relevant padding to the body. (A navbar-static-top with no padding on the body does not encounter this issue) Fixes #15078
|
Is it possible to add a unit test for this? |
|
Thanks, much appreciated! |
|
Also fixes #15097. |
|
New unit test correctly fails with old code and passes with the proposed change, on PhantomJS. |
|
Running Sauce cross-browser tests: https://travis-ci.org/twbs/bootstrap/jobs/41276707 |
|
Sauce tests passed, although iOS had to retry a couple times, so we probably want to increase the setTimeout delays a bit, to prevent the test suite from becoming flaky. |
|
Retrying with 250ms delays instead of 0ms delays: https://travis-ci.org/twbs/bootstrap/jobs/41307952 |
|
LGTM. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use scrollTop instead of colliderTop which uses the elements
offset().top, as the offset top does not account for padding.
This issue can be replicated by using a navbar-fixed-top and applying
relevant padding to the body. (A navbar-static-top with no padding on
the body does not encounter this issue)
Fixes #15078