Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Glyphicons 1.9 #15213

Closed
wants to merge 1 commit into from
Closed

Glyphicons 1.9 #15213

wants to merge 1 commit into from

Conversation

bastienmoulia
Copy link
Contributor

No description provided.

@cvrebert
Copy link
Collaborator

This is based off of a year-old parent commit (73f1084). Please use a recent commit as the base for your pull request.
Also, where did you obtain the font files?

@cvrebert cvrebert changed the title glyphicon 1.9 Glyphicons 1.9 Nov 24, 2014
@cvrebert cvrebert added the css label Nov 24, 2014
@bastienmoulia
Copy link
Contributor Author

I probably fork the wrong branch... I will retry.
I have a PRO Glyphicons account, so all the Halflings fonts (free) are on it.

@mdo mdo added this to the v3.3.2 milestone Nov 30, 2014
@mdo
Copy link
Member

mdo commented Nov 30, 2014

Added correctly in bcb90ef.

@mdo mdo closed this Nov 30, 2014
@Quy
Copy link
Contributor

Quy commented Dec 11, 2014

Please document to #15103.

@juthilo juthilo mentioned this pull request Dec 11, 2014
@cvrebert
Copy link
Collaborator

@Quy Done. Thanks!

@cvrebert
Copy link
Collaborator

The .glyphicon-door and .glyphicon-key added by this are outside of the Unicode BMP, which will cause a partial recurrence of #10106!

@cvrebert cvrebert reopened this Dec 11, 2014
@bastienmoulia
Copy link
Contributor Author

I just send an email to Jan Kovařík (glyphicons) to ask for the change of this 2 unicode in the fonts.

@mdo
Copy link
Member

mdo commented Dec 21, 2014

Punting new issue to #15419.

@mdo mdo closed this Dec 21, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants