Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

More docs accessibility tweaks #15327

Merged
merged 5 commits into from
Dec 8, 2014
Merged

More docs accessibility tweaks #15327

merged 5 commits into from
Dec 8, 2014

Conversation

patrickhlauke
Copy link
Member

No description provided.

@patrickhlauke
Expand advice for optional icons with hidden labels
52e4b87 
to clarify/hint that a ``<label class="sr-only">`` is not the only way
to do it
@patrickhlauke
Split out/clarify <select> and multiple
c918127
@patrickhlauke
Copy link
Member Author

/cc @cvrebert about 0447a07

@cvrebert
Copy link
Collaborator

cvrebert commented Dec 8, 2014

No idea offhand. I'd recommend tracking down its introduction via Git Blame.

@patrickhlauke
Copy link
Member Author

Seems the tabindex="-1" has been hanging around for a long time - going back as far as 2013, when most dropdowns etc had it. So, assume this was just an oversight when the rest of things were made keyboard-usable, rather than intentional... @mdo ?

@mdo
Copy link
Member

mdo commented Dec 8, 2014

:shipit:

@patrickhlauke
Callout for labelling of input groups
eee2757 
plus a few suggested approaches (in some cases, elided, as the actual
content of the label - being a generic example - is not important)
@patrickhlauke
Use aria-label for pagination prev/next
24bc102 
Cleaner alternative to using ``<span class="sr-only">``
@patrickhlauke
Make main segmented button keyboard-focusable
285ec70 
unless there's a reason why ``tabindex="-1"`` was dropped in there...
@cvrebert
Copy link
Collaborator

cvrebert commented Dec 8, 2014

@patrickhlauke Protip: Include [skip sauce] (on its own line) in the commit message when making docs-only changes; it skips the cross-browser JS tests, which speeds up the Travis build.

@cvrebert cvrebert added this to the v3.3.2 milestone Dec 8, 2014
patrickhlauke added a commit that referenced this pull request Dec 8, 2014
@patrickhlauke
Merge pull request #15327 from patrickhlauke/docs-accessibility-tweaks2
7cff5bb 
More docs accessibility tweaks
@patrickhlauke patrickhlauke merged commit 7cff5bb into twbs:master Dec 8, 2014
@juthilo juthilo mentioned this pull request Dec 9, 2014
Closed
@danielnixon danielnixon mentioned this pull request Jan 19, 2015
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
accessibility docs
Projects
None yet
Milestone
v3.3.2
Development

Successfully merging this pull request may close these issues.
4 participants
@patrickhlauke @cvrebert @mdo @AlchemyUnited