Redo .card-deck and .card-group so they're always flex #22860
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
|
@mdo i'm getting this behavior on the card-groups on the currect v4-dev branch, and i think it's caused by this pr is the margin on the bottom supposed to be overridden? |
|
Hmm yeah margin should be overridden. Those should be equal height. |
|
i'll see if i can fix it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This rearranges the Sass source code for card decks and groups so that they are always flex containers. It also addresses the vertical spacing for them on the xs breakpoint by adding some default margin there (that's later overridden).
Fixes #22206