Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix unwanted body padding when a modal is opened #23718

Merged
merged 7 commits into from
Sep 2, 2017
Merged

Fix unwanted body padding when a modal is opened #23718

merged 7 commits into from
Sep 2, 2017

Commits on Aug 28, 2017

  1. Add failing test 

    When the body does not overflow (achieved by hiding the QUnit container), it should not be given a margin.
    @TechDavid
    TechDavid committed Aug 28, 2017
    Configuration menu
    Copy the full SHA
    487513f View commit details
    Browse the repository at this point in the history

  2. Fix unwanted body padding when a modal opens 

    Prevents the test from failing
    @TechDavid
    TechDavid committed Aug 28, 2017
    Configuration menu
    Copy the full SHA
    a4fff7c View commit details
    Browse the repository at this point in the history

  3. Use jQuery outerWidth instead of offsetWidth

    @TechDavid
    TechDavid committed Aug 28, 2017
    Configuration menu
    Copy the full SHA
    2725acc View commit details
    Browse the repository at this point in the history

  4. Use getBoundingClientRect instead of jQuery

    @TechDavid
    TechDavid committed Aug 28, 2017
    Configuration menu
    Copy the full SHA
    3f2a8db View commit details
    Browse the repository at this point in the history

Commits on Aug 29, 2017

  1. Fix unit tests in PhantomJS 

    Use a virtual scrollbar as this is simpler than having a real one (overflow: scroll doesn't seem to work in Phantom), and disable it for the new test.

One test has also been altered to prevent erroneous fails when other inline styles are added to the body (e.g. overflow).
    @TechDavid
    TechDavid committed Aug 29, 2017
    Configuration menu
    Copy the full SHA
    2622a01 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'v4-dev' into fix-unwanted-padding-on-modal

    @TechDavid
    TechDavid committed Aug 29, 2017
    Configuration menu
    Copy the full SHA
    a766dd5 View commit details
    Browse the repository at this point in the history

Commits on Sep 2, 2017

  1. Merge branch 'v4-dev' into fix-unwanted-padding-on-modal

    @Johann-S
    Johann-S committed Sep 2, 2017
    Configuration menu
    Copy the full SHA
    37e1053 View commit details
    Browse the repository at this point in the history