Modal javascript fix and doc update #255
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -56,13 +56,15 @@ | |||
| this.settings = $.extend({}, $.fn.modal.defaults) | |||
| this.$element = $(content) | |||
| .delegate('.close', 'click.modal', $.proxy(this.hide, this)) | |||
|
|
|||
| if ( !options ) { | |||
| options = {} | |||
There was a problem hiding this comment.
i don't think this is neccesary.
$.extend({foo: 'bar'}, null) // seems to work fine
|
Not sure how those other commits got in there, a bit new to Github pull requests. What should I do? I'd love to have contributed to this awesome project. |
|
Those got there because you sent a pull request from your master branch rather than having a feature branch. Not a big deal though - git can be tricky |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed a few things I had trouble with on the modals when looking at docs