Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make tabs plugin play well with nested tabs #329

Merged
merged 1 commit into from Sep 30, 2011
Merged

make tabs plugin play well with nested tabs #329

merged 1 commit into from Sep 30, 2011

Conversation

ghost
Copy link

@ghost ghost commented Sep 28, 2011

tweaked bootstrap-tabs plugin active tab selector to allow for nested tabs

@mdo
Copy link
Member

mdo commented Sep 29, 2011

Nested tabs, huh? When is it a good idea to use nested tabs?

@ghost
Copy link
Author

ghost commented Sep 29, 2011

There's no issue whatsoever with nested tabs, two tab rows is perfectly okay as long as the second row has a clear hierarchical relation with the top row and there's a clear visual distinction, as there is in the project I'm working on.

fat added a commit that referenced this pull request Sep 30, 2011
make tabs plugin play well with nested tabs
@fat fat merged commit fda10a6 into twbs:master Sep 30, 2011
@fat
Copy link
Member

fat commented Sep 30, 2011

thanks!

@ghost
Copy link
Author

ghost commented Sep 30, 2011

Awesome =)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants