Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix prevented show event disables modals with fade class from being displayed again #34085

Merged
merged 3 commits into from
May 24, 2021
Merged

Fix prevented show event disables modals with fade class from being displayed again #34085

merged 3 commits into from
May 24, 2021

Commits on May 22, 2021

  1. test(modal): add case for prevented calls to show with fading enabled

    @alpadev
    alpadev committed May 22, 2021
    Configuration menu
    Copy the full SHA
    4d8a65c View commit details
    Browse the repository at this point in the history

  2. fix(modal): change the order we return from show() method 

    In case of a modal with fading enabled, a prevented show event can cause show to not showing the modal anymore.

See #34055
    @alpadev
    alpadev committed May 22, 2021
    Configuration menu
    Copy the full SHA
    99979c3 View commit details
    Browse the repository at this point in the history

  3. test(modal): fix broken test case

    @alpadev
    alpadev committed May 22, 2021
    Configuration menu
    Copy the full SHA
    3c5aa32 View commit details
    Browse the repository at this point in the history