[WIP] Fix documentation versions selection #36221
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is for the moment a proposal to revert modifications added to handle the versions in the dropdown in the header.
Here are the issues that I can observe:
Based on this obervation even if I understand perfectly the need I'm wondering if this system of keeping the context will be easy to maintain in the future. If we decide to change the doc or examples sitemaps, none of the links would work without a modification of the previous documentations.
Depending on when the v5.2.0 will be released, it could be safer to revert this mechanism and implement it with all the cases in v5.2.1 or v5.3.0. Thoughts?
/CC @mdo
Feel free to close this PR if it's already been discussed
Live preview