Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Fix documentation versions selection #36221

Closed

Conversation

julien-deramond
Copy link
Member

@julien-deramond julien-deramond commented Apr 25, 2022

This PR is for the moment a proposal to revert modifications added to handle the versions in the dropdown in the header.

Here are the issues that I can observe:

Based on this obervation even if I understand perfectly the need I'm wondering if this system of keeping the context will be easy to maintain in the future. If we decide to change the doc or examples sitemaps, none of the links would work without a modification of the previous documentations.

Depending on when the v5.2.0 will be released, it could be safer to revert this mechanism and implement it with all the cases in v5.2.1 or v5.3.0. Thoughts?

/CC @mdo

Feel free to close this PR if it's already been discussed

Live preview

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants