-
-
Notifications
You must be signed in to change notification settings - Fork 78.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix StackBlitz Popovers and Tooltips examples #36449
Merged
mdo
merged 5 commits into
main
from
main-jd-refine-popovers-and-tooltips-examples-for-stackblitz
Jun 20, 2022
Merged
Fix StackBlitz Popovers and Tooltips examples #36449
mdo
merged 5 commits into
main
from
main-jd-refine-popovers-and-tooltips-examples-for-stackblitz
Jun 20, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GeoSot
force-pushed
the
main-jd-refine-popovers-and-tooltips-examples-for-stackblitz
branch
from
May 31, 2022 10:39
c25eb38
to
5ac36b6
Compare
mdo
reviewed
Jun 1, 2022
93 tasks
Following a discussion with @GeoSot a4153f4 contains the following modifications:
|
mdo
reviewed
Jun 8, 2022
site/layouts/partials/callout-warning-data-bs-title-vs-title.md
Outdated
Show resolved
Hide resolved
GeoSot
force-pushed
the
main-jd-refine-popovers-and-tooltips-examples-for-stackblitz
branch
from
June 9, 2022 17:59
e40ed53
to
31ac201
Compare
GeoSot
approved these changes
Jun 9, 2022
I think is fine now. Thanks a lot @julien-deramond 😄 |
Co-authored-by: Mark Otto <markd.otto@gmail.com>
GeoSot
force-pushed
the
main-jd-refine-popovers-and-tooltips-examples-for-stackblitz
branch
from
June 20, 2022 12:12
31ac201
to
48a081f
Compare
mdo
approved these changes
Jun 20, 2022
mdo
deleted the
main-jd-refine-popovers-and-tooltips-examples-for-stackblitz
branch
June 20, 2022 14:19
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Step 2 of #36391
This PR contains
Newstackblitz
option for the example shortcodejs_snippet
tostackblitz_add_js
option for the example shortcode in order to identify easily what's related to StackBlitzHide the StackBlitz edit button of the first Popover example and usedata-bs-title
instead oftitle
for the other Popover examples as discussed in Allow popovers examples to be tried on StackBlitz #36127 (comment)data-bs-title
instead oftitle
for the Tooltip and Popover examplesLive previews
Popovers
Tooltips