Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: Minor fixes in tables. #37047

Merged
merged 1 commit into from
Sep 1, 2022

Conversation

louismaximepiton
Copy link
Member

Few fixes in tables.

This leads me to other questions:

  • Why do we have Tab javascript documentation inside List-Group? Seems like it was just a copy-paste.
  • Why the Tab javascript methods aren't in a <table>?

Copy link
Member

@julien-deramond julien-deramond left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Modifications LGTM! They bring more consistency in the docs.

I don't have all the history to answer to your questions in the description. I let others respond.

@MadhavanBS

This comment was marked as duplicate.

@mdo
Copy link
Member

mdo commented Sep 1, 2022

  • Why do we have Tab javascript documentation inside List-Group? Seems like it was just a copy-paste.

I think just to indicate that list groups can be used with the Tab plugin. I think in v6, maybe v5.x, we could split the Navs & Tabs page into separate pages. Tabs is just about JS functionality and works with any of our navs and list groups as far as I know. I think there was a PR to add support for arbitrary elements but I can't recall. @GeoSot might remember.

  • Why the Tab javascript methods aren't in a <table>?

They definitely should be! Maybe open an issue to track, or tackle in a PR if you like :).

@mdo
Copy link
Member

mdo commented Sep 1, 2022

This PR also has some conflicts—can you update and we can merge?

@mdo mdo merged commit 77e17e3 into twbs:main Sep 1, 2022
@louismaximepiton louismaximepiton deleted the main-lmp-docs-tables-fixes branch September 2, 2022 10:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants