Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: consistency between custom buttons, popovers and tooltips #38681

Merged
merged 1 commit into from
Jun 3, 2023

Conversation

julien-deramond
Copy link
Member

@julien-deramond julien-deramond commented May 31, 2023

Description

This PR updates _component-examples.scss for .custom-tooltip and .custom-popover.

Custom tooltip background color is set to violet and the color is forced to white to avoid contrast issues (in the actual main branch, on dark mode, the text color is not accessible).

Custom popover background and border colors are set to violet.

Motivation & Context

IMO this change can enhance the comprehension of our custom examples in the documentation by using a color absent from our default theme colors. It enforces the consistency with the custom buttons in https://twbs-bootstrap.netlify.app/docs/5.3/components/buttons/#variables which is better, still IMO, compared to the corresponding popovers and tooltips examples.

Type of changes

  • Enhancement (non-breaking change)

Checklist

  • I have read the contributing guidelines
  • My code follows the code style of the project (using npm run lint)
  • My change introduces changes to the documentation
  • I have updated the documentation accordingly
  • (N/A) I have added tests to cover my changes
  • All new and existing tests passed

Live previews

@julien-deramond julien-deramond marked this pull request as ready for review May 31, 2023 10:44
@julien-deramond julien-deramond requested a review from a team as a code owner May 31, 2023 10:44
@mdo mdo merged commit 6e49236 into main Jun 3, 2023
@mdo mdo deleted the main-jd-consistent-custom-components branch June 3, 2023 17:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants