Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Sass properties order for newer stylelint-config-recess-order #38851

Merged
merged 1 commit into from
Jun 30, 2023

Conversation

XhmikosR
Copy link
Member

@XhmikosR XhmikosR commented Jun 30, 2023

Description

Motivation & Context

Type of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring (non-breaking change)
  • Breaking change (fix or feature that would change existing functionality)

Checklist

  • I have read the contributing guidelines
  • My code follows the code style of the project (using npm run lint)
  • My change introduces changes to the documentation
  • I have updated the documentation accordingly
  • I have added tests to cover my changes
  • All new and existing tests passed

Live previews

Related issues

@XhmikosR XhmikosR added the css label Jun 30, 2023
@XhmikosR XhmikosR marked this pull request as ready for review June 30, 2023 06:13
@XhmikosR XhmikosR requested a review from a team as a code owner June 30, 2023 06:13
Copy link
Member

@julien-deramond julien-deramond left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Modification looks good to me.
This is a preparation for an update of stylelint-config-twbs-bootstrap? Because the linter is already happy with the content of the main branch.

@XhmikosR
Copy link
Member Author

It's a minor stylelint-config-recess-order version bump that's causing the new issues, so technically without a lock file we'd see the issues here too.

I'll make it a major stylelint-config-twbs-bootstrap bump just to be safe, though.

@XhmikosR XhmikosR merged commit 1ab75c8 into main Jun 30, 2023
@XhmikosR XhmikosR deleted the xmr/scss-order branch June 30, 2023 06:52
romankupchak93 pushed a commit to romankupchak93/bootstrap that referenced this pull request Jan 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants