Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CI: stop running coveralls in forks #39096

Merged
merged 3 commits into from
Jan 9, 2024
Merged

CI: stop running coveralls in forks #39096

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
fe6b9ca
CI: Run Coveralls action only in our repo
XhmikosR Aug 23, 2023
9865408
Update js.yml
XhmikosR Dec 23, 2023
23e803b
Merge branch 'main' into xmr/ci
XhmikosR Dec 23, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .github/workflows/js.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,6 +46,7 @@ jobs:

- name: Run Coveralls
uses: coverallsapp/github-action@v2
if: github.repository == 'twbs/bootstrap'
Copy link
Member

@julien-deramond julien-deramond Oct 14, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe both are working but I've seen and used another approach to do that:

Suggested change
if: github.repository == 'twbs/bootstrap'
if: github.repository_owner == 'twbs'

If I remember well, the job starts but is canceled because of the condition.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we could probably just use this too:

if: ${{ !github.event.repository.fork }}

with:
github-token: "${{ secrets.GITHUB_TOKEN }}"
path-to-lcov: "./js/coverage/lcov.info"