Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: Add a contextual color mode switcher for each example #39274

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

louismaximepiton
Copy link
Member

@louismaximepiton louismaximepiton commented Oct 5, 2023

Description

⚠️ Merge after #39328.
⚠️ I tried to have at least the accessible behavior, but the rest might not be clean.
Add a color-mode switcher to every example.

Motivation & Context

Ease the color change checks for users.
Ease the reviews on our side.

Type of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring (non-breaking change)
  • Breaking change (fix or feature that would change existing functionality)

Checklist

  • I have read the contributing guidelines
  • My code follows the code style of the project (using npm run lint)
  • My change introduces changes to the documentation
  • I have updated the documentation accordingly
  • I have added tests to cover my changes
  • All new and existing tests passed

Live previews

Every component/form will have this button added.

Related issues

@louismaximepiton louismaximepiton marked this pull request as ready for review October 23, 2023 15:07
@louismaximepiton louismaximepiton requested review from a team as code owners October 23, 2023 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Needs review
Development

Successfully merging this pull request may close these issues.

1 participant