Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix new stylelint-config-recess-order issues #40887

Merged
merged 3 commits into from
Oct 2, 2024
Merged

Fix new stylelint-config-recess-order issues #40887

merged 3 commits into from
Oct 2, 2024
+2 −2

Conversation

XhmikosR
Copy link
Member

@XhmikosR XhmikosR commented Oct 1, 2024

No description provided.

@XhmikosR
Copy link
Member Author

XhmikosR commented Oct 2, 2024

@julien-deramond LGTY?

@julien-deramond
Copy link
Member

julien-deramond commented Oct 2, 2024 •
edited
Loading

@julien-deramond LGTY?

I don't know if the PR must be rebased onto something or if there's a missing dep bump, but you got a "Lint" error in the workflow (see https://github.com/twbs/bootstrap/actions/runs/11127737768/job/30920759172?pr=40887):

scss/_nav.scss
  173:5  ✖  Expected "flex-basis" to come before "flex-grow"  order/properties-order

scss/_navbar.scss
  143:3  ✖  Expected "flex-basis" to come before "flex-grow"  order/properties-order

✖ 2 problems (2 errors, 0 warnings)

ERROR: "css-lint-stylelint" exited with 2.

@XhmikosR
Copy link
Member Author

XhmikosR commented Oct 2, 2024

Yeah that's normal, it will work after #40895

@julien-deramond
Copy link
Member

In that case, yeah, no problem with this modification :)

@XhmikosR
Copy link
Member Author

XhmikosR commented Oct 2, 2024

My point is if any of the behavior changes because some properties were overridden, stormwarning/stylelint-config-recess-order#385

julien-deramond
julien-deramond approved these changes Oct 2, 2024
View reviewed changes
Copy link
Member

@julien-deramond julien-deramond left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for when #40895 will be merged

@XhmikosR XhmikosR changed the base branch from main to dependabot/npm_and_yarn/development-dependencies-dbc5cceb5e October 2, 2024 05:06
@XhmikosR XhmikosR marked this pull request as ready for review October 2, 2024 05:06
@XhmikosR XhmikosR requested a review from a team as a code owner October 2, 2024 05:06
@XhmikosR XhmikosR merged commit b029f11 into dependabot/npm_and_yarn/development-dependencies-dbc5cceb5e Oct 2, 2024
14 of 15 checks passed
@XhmikosR XhmikosR deleted the XhmikosR-patch-1 branch October 2, 2024 05:07
XhmikosR added a commit that referenced this pull request Oct 2, 2024
@dependabot @XhmikosR
Build(deps-dev): Bump the development-dependencies group across 1 dir…
5ee90fe 
…ectory with 9 updates (#40895)

* Build(deps-dev): Bump the development-dependencies group across 1 directory with 9 updates

Bumps the development-dependencies group with 9 updates in the / directory:

| Package | From | To |
| --- | --- | --- |
| [@docsearch/js](https://github.com/algolia/docsearch) | `3.6.1` | `3.6.2` |
| [@rollup/plugin-commonjs](https://github.com/rollup/plugins/tree/HEAD/packages/commonjs) | `26.0.1` | `28.0.0` |
| [@rollup/plugin-node-resolve](https://github.com/rollup/plugins/tree/HEAD/packages/node-resolve) | `15.2.3` | `15.3.0` |
| [@rollup/plugin-replace](https://github.com/rollup/plugins/tree/HEAD/packages/replace) | `5.0.7` | `6.0.1` |
| [eslint-plugin-html](https://github.com/BenoitZugmeyer/eslint-plugin-html) | `8.1.1` | `8.1.2` |
| [nodemon](https://github.com/remy/nodemon) | `3.1.4` | `3.1.7` |
| [postcss](https://github.com/postcss/postcss) | `8.4.45` | `8.4.47` |
| [sass](https://github.com/sass/dart-sass) | `1.77.8` | `1.78.0` |
| [stylelint-config-twbs-bootstrap](https://github.com/twbs/stylelint-config-twbs-bootstrap) | `15.0.0` | `15.1.0` |



Updates `@docsearch/js` from 3.6.1 to 3.6.2
- [Release notes](https://github.com/algolia/docsearch/releases)
- [Changelog](https://github.com/algolia/docsearch/blob/main/CHANGELOG.md)
- [Commits](algolia/docsearch@v3.6.1...v3.6.2)

Updates `@rollup/plugin-commonjs` from 26.0.1 to 28.0.0
- [Changelog](https://github.com/rollup/plugins/blob/master/packages/commonjs/CHANGELOG.md)
- [Commits](https://github.com/rollup/plugins/commits/commonjs-v28.0.0/packages/commonjs)

Updates `@rollup/plugin-node-resolve` from 15.2.3 to 15.3.0
- [Changelog](https://github.com/rollup/plugins/blob/master/packages/node-resolve/CHANGELOG.md)
- [Commits](https://github.com/rollup/plugins/commits/node-resolve-v15.3.0/packages/node-resolve)

Updates `@rollup/plugin-replace` from 5.0.7 to 6.0.1
- [Changelog](https://github.com/rollup/plugins/blob/master/packages/replace/CHANGELOG.md)
- [Commits](https://github.com/rollup/plugins/commits/json-v6.0.1/packages/replace)

Updates `eslint-plugin-html` from 8.1.1 to 8.1.2
- [Changelog](https://github.com/BenoitZugmeyer/eslint-plugin-html/blob/main/CHANGELOG.md)
- [Commits](BenoitZugmeyer/eslint-plugin-html@v8.1.1...v8.1.2)

Updates `nodemon` from 3.1.4 to 3.1.7
- [Release notes](https://github.com/remy/nodemon/releases)
- [Commits](remy/nodemon@v3.1.4...v3.1.7)

Updates `postcss` from 8.4.45 to 8.4.47
- [Release notes](https://github.com/postcss/postcss/releases)
- [Changelog](https://github.com/postcss/postcss/blob/main/CHANGELOG.md)
- [Commits](postcss/postcss@8.4.45...8.4.47)

Updates `sass` from 1.77.8 to 1.78.0
- [Release notes](https://github.com/sass/dart-sass/releases)
- [Changelog](https://github.com/sass/dart-sass/blob/main/CHANGELOG.md)
- [Commits](sass/dart-sass@1.77.8...1.78.0)

Updates `stylelint-config-twbs-bootstrap` from 15.0.0 to 15.1.0
- [Release notes](https://github.com/twbs/stylelint-config-twbs-bootstrap/releases)
- [Commits](twbs/stylelint-config-twbs-bootstrap@v15.0.0...v15.1.0)

---
updated-dependencies:
- dependency-name: "@docsearch/js"
  dependency-type: direct:development
  update-type: version-update:semver-patch
  dependency-group: development-dependencies
- dependency-name: "@rollup/plugin-commonjs"
  dependency-type: direct:development
  update-type: version-update:semver-major
  dependency-group: development-dependencies
- dependency-name: "@rollup/plugin-node-resolve"
  dependency-type: direct:development
  update-type: version-update:semver-minor
  dependency-group: development-dependencies
- dependency-name: "@rollup/plugin-replace"
  dependency-type: direct:development
  update-type: version-update:semver-major
  dependency-group: development-dependencies
- dependency-name: eslint-plugin-html
  dependency-type: direct:development
  update-type: version-update:semver-patch
  dependency-group: development-dependencies
- dependency-name: nodemon
  dependency-type: direct:development
  update-type: version-update:semver-patch
  dependency-group: development-dependencies
- dependency-name: postcss
  dependency-type: direct:development
  update-type: version-update:semver-patch
  dependency-group: development-dependencies
- dependency-name: sass
  dependency-type: direct:development
  update-type: version-update:semver-minor
  dependency-group: development-dependencies
- dependency-name: stylelint-config-twbs-bootstrap
  dependency-type: direct:development
  update-type: version-update:semver-minor
  dependency-group: development-dependencies
...

Signed-off-by: dependabot[bot] <support@github.com>

* Fix new stylelint-config-recess-order issues (#40887)

* Pin sass to 1.78

If the issues are fixed, it should be updated again along with the caret operator.

---------

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: XhmikosR <xhmikosr@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@julien-deramond julien-deramond julien-deramond approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@XhmikosR @julien-deramond