Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unnecessary duplicated CSS class name #40900

Merged

Conversation

MohamadSalman11
Copy link
Contributor

Description

On the home page, in the 'Get Started' section, the 'Read installation docs' paragraph had a duplicate class name:
'justify-content-md-start' and 'justify-content-md-center'. Since both classes work when the screen size is >768px , the 'justify-content-md-start' class is not needed.

Motivation & Context

Remove unnecessary classes to keep the code clean and easy to maintain

Type of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring (non-breaking change)
  • Breaking change (fix or feature that would change existing functionality)

Checklist

  • I have read the contributing guidelines
  • My code follows the code style of the project (using npm run lint)
  • My change introduces changes to the documentation
  • I have updated the documentation accordingly
  • I have added tests to cover my changes
  • All new and existing tests passed

Live previews

Related issues

@julien-deramond julien-deramond requested review from a team and julien-deramond and removed request for a team October 3, 2024 10:57
Copy link
Member

@julien-deramond julien-deramond left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @MohamadSalman11
Good catch! Indeed, this class is not needed :)

@julien-deramond julien-deramond merged commit f73113c into twbs:main Oct 7, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants