Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: correct typo in background-blend-mode value #40931

Merged

Conversation

MohamadSalman11
Copy link
Contributor

@MohamadSalman11 MohamadSalman11 commented Oct 10, 2024

Description

Corrected 'multiple' to 'multiply' for background-blend-mode because 'multiple' is not a valid value.

Motivation & Context

Type of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring (non-breaking change)
  • Breaking change (fix or feature that would change existing functionality)

Checklist

  • I have read the contributing guidelines
  • My code follows the code style of the project (using npm run lint)
  • My change introduces changes to the documentation
  • I have updated the documentation accordingly
  • I have added tests to cover my changes
  • All new and existing tests passed

Live previews

Related issues

Copy link
Member

@julien-deramond julien-deramond left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR, @MohamadSalman11! Good catch—multiple is indeed not a valid value. TBH, I'm not entirely sure if background-blend-mode does actually anything in this case, but let's keep it for now, just in case.

@MohamadSalman11
Copy link
Contributor Author

Thanks for the PR, @MohamadSalman11! Good catch—multiple is indeed not a valid value. TBH, I'm not entirely sure if background-blend-mode does actually anything in this case, but let's keep it for now, just in case.

Hi @julien-deramond ,

I was also wondering if the background-blend-mode actually does anything, as I don’t see any changes. It might be useful in a specific scenario. If you find anything, I can gladly make a new commit to remove it. Thanks a lot!

@julien-deramond julien-deramond merged commit 88bb06b into twbs:main Oct 10, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants