update terminal-notifier for yosemite #14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
twe4ked
added a commit
that referenced
this pull request
Jul 27, 2014
Add OS X Yosemite (10.10) support
|
Thanks for this, I seem to have messed up some things with RSpec 3 so I'm going to fix those before I release a new version. On a side note, what version of RSpec are you using? |
|
I'm currently using rspec 3.0.0. Aditionally, i had to use `rspec-legacy_formatters' to make it work with rspec 3. |
|
I've released 0.1.1 with your changes, let me know how it goes. I'm going to work on removing the need for |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previous versions of terminal-notifier didn't support os x yosemite. I changed the terminal-notifier version according to this issue and tried a couple of test suites. It seems to work fine in yosemite beta just doing this.