Automatic visibility of stack_snapshot dependencies to vendored packages #1583
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Radvendii
reviewed
Aug 23, 2021
Radvendii
approved these changes
Aug 23, 2021
If a vendored package depends on an otherwise not public package in the snapshot, then it is made visible to this vendored package. To handle executable components (tool dependencies) `stack_snapshot` generates a JSON file listing all components and the `-exe` repository reads this file to generate the necessary aliases with the correct visibilities.
Co-authored-by: Taeer Bar-Yam <Radvendii@users.noreply.github.com>
aherrmann
force-pushed
the
stack-visibility
branch
from
d0120f9
to
454139c
Compare
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1571
If a vendored package depends on an otherwise not public package in the snapshot, then this dependency is made visible to the vendored package.
To handle executable components (tool dependencies)
stack_snapshotgenerates a JSON file listing all components and the-exerepository reads this file to generate the necessary aliases with the correct visibilities.