Move start script to bindists & document #804
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The user is now immediately able to build a simple Haskell binary. We provide a full minimal example of a working project, getting the user up & running from a state they know is working (or at least one we guarantee to work). Each of the generated bazel files is documented, to ease understanding of the template.
Profpatsch
force-pushed
the
start-script-bindists
branch
from
6237cff
to
0aeca68
Compare
mboes
reviewed
Apr 1, 2019
Profpatsch
force-pushed
the
start-script-bindists
branch
from
0c371ef
to
1605b76
Compare
|
So, importing the |
|
Our version of Skydoc is deprecated but unfortunately there is no good replacement for it as of yet. The new Stardoc is a lot less feature complete. |
Some bindist hashes were broken, because they were copied by hand. This means a `rules_haskell` release is broken, at least for users who try to use the bindists we provide. One only notices after downloading a heavy bindists and the hashes don’t match, leading to a frustrating experience. Running the `gen-ghc-bindist` uses the official upstream hashes to generate a bzl file (really: dump a python dict), which can `load`ed by bazel, eliminating future maintenance errors.
Remove the repository override, because we always deploy the current start script from master, but it fetches the latest release (not master), so we should test that. Move from a simple fetch to testing the buildable example.
Profpatsch
force-pushed
the
start-script-bindists
branch
from
aaec4d8
to
f6878c7
Compare
Previously the start script generated a nixpkgs-compatible WORKSPACE, but since we switched it to bindists now, it should run in the bindist CI.
Profpatsch
force-pushed
the
start-script-bindists
branch
from
f6878c7
to
7ea18f8
Compare
Profpatsch
force-pushed
the
start-script-bindists
branch
from
3a70563
to
b432574
Compare
mboes
approved these changes
Apr 2, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR improves the start script and the bindists.