Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(cache, model): stage channel message types #2147

Merged
merged 4 commits into from
Feb 17, 2023
Merged

feat(cache, model): stage channel message types #2147

merged 4 commits into from
Feb 17, 2023

Conversation

suneettipirneni
Copy link
Member

@suneettipirneni suneettipirneni commented Feb 15, 2023 •
edited by zeylahellyer
Loading

feat(cache, model): stage channel message types

Add support for the new message types for text channels within stage
channels. These variants are all system messages, and are:

  • StageStart when a stage has started;
  • StageEnd when a stage has ended;
  • StageSpeaker when someone becomes a speaker; and
  • StageTopic when the topic of the stage changes.

Closes #2146.

@github-actions github-actions bot added c-cache Affects the cache crate c-model Affects the model crate t-feature Addition of a new feature labels Feb 15, 2023
@suneettipirneni suneettipirneni force-pushed the feat/stage-video branch 2 times, most recently from 9657a82 to 74664a1 Compare February 15, 2023 21:07
zeylahellyer
zeylahellyer approved these changes Feb 16, 2023
View reviewed changes
Copy link
Member

@zeylahellyer zeylahellyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks pretty good, just a request for a small bit of documentation!

twilight-model/src/guild/mod.rs Outdated Show resolved Hide resolved
@7596ff 7596ff added the d-api Change related to Discord's API. label Feb 16, 2023
@zeylahellyer zeylahellyer added the w-do-not-merge PR is blocked or deferred label Feb 17, 2023
@github-actions github-actions bot removed the c-cache Affects the cache crate label Feb 17, 2023
@zeylahellyer zeylahellyer mentioned this pull request Feb 17, 2023
Merged
@zeylahellyer zeylahellyer changed the title feat(model, cache): Add support for stage video feat(cache, model): stage channel message types Feb 17, 2023
@zeylahellyer zeylahellyer removed the w-do-not-merge PR is blocked or deferred label Feb 17, 2023
@zeylahellyer
Copy link
Member

I split the max_stage_video_channel_users field to #2152 since its docs PR is unmerged. But since the message types API docs PR is merged, we can merge this right away. The other one has been open for more than half a year.

@zeylahellyer zeylahellyer merged commit e9e193a into twilight-rs:main Feb 17, 2023
@suneettipirneni suneettipirneni deleted the feat/stage-video branch February 17, 2023 19:07
Gelbpunkt added a commit that referenced this pull request Sep 15, 2024
@zeylahellyer @suneettipirneni @Gelbpunkt
feat(cache, model): add max_stage_video_channel_users (#2152)
8035434 
Add support for the guild field `max_stage_video_channel_users`, which
functions similarly to related fields such as `max_video_channel_users`.
This has been added on the `Guild` model type and the `CachedGuild`
inmemory cache type.

Split out from #2147.

Co-authored-by: suneettipirneni <suneettipirneni@icloud.com>
Co-authored-by: Jens Reidel <adrian@travitia.xyz>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zeylahellyer zeylahellyer zeylahellyer approved these changes

Assignees
No one assigned
Labels
c-model Affects the model crate d-api Change related to Discord's API. t-feature Addition of a new feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support stage channel message types
3 participants
@suneettipirneni @zeylahellyer @7596ff