Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(model, cache): add managed field to Channel #2148

Merged
merged 4 commits into from
Feb 17, 2023
Merged

feat(model, cache): add managed field to Channel #2148

merged 4 commits into from
Feb 17, 2023

Conversation

suneettipirneni
Copy link
Member

Adds managed field to channels as per the docs PR: discord/discord-api-docs#5867

@github-actions github-actions bot added c-cache Affects the cache crate c-model Affects the model crate t-feature Addition of a new feature labels Feb 15, 2023
zeylahellyer
zeylahellyer approved these changes Feb 16, 2023
View reviewed changes
Copy link
Member

@zeylahellyer zeylahellyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks pretty good thanks, just a suggestion about the documentation

twilight-model/src/channel/mod.rs Outdated Show resolved Hide resolved
@zeylahellyer zeylahellyer merged commit 1366d66 into twilight-rs:main Feb 17, 2023
@zeylahellyer
Copy link
Member

Thanks for the PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@7596ff 7596ff 7596ff approved these changes

@zeylahellyer zeylahellyer Awaiting requested review from zeylahellyer

Assignees
No one assigned
Labels
c-cache Affects the cache crate c-model Affects the model crate t-feature Addition of a new feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@suneettipirneni @zeylahellyer @7596ff