Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(model, cache): add support for voice messages #2196

Merged
merged 2 commits into from
Apr 24, 2023
Merged

feat(model, cache): add support for voice messages #2196

merged 2 commits into from
Apr 24, 2023

Conversation

suneettipirneni
Copy link
Member

Adds the waveform and duration_secs to the Attachment structure. In addition, the new SEND_VOICE_MESSAGES permission has been added.

Ref:

@github-actions github-actions bot added c-cache Affects the cache crate c-model Affects the model crate t-feature Addition of a new feature labels Apr 15, 2023
@suneettipirneni suneettipirneni changed the title feat(model): add support for voice messages feat(model, cache): add support for voice messages Apr 15, 2023
@suneettipirneni suneettipirneni self-assigned this Apr 23, 2023
@suneettipirneni suneettipirneni marked this pull request as ready for review April 23, 2023 22:40
itohatweb
itohatweb previously approved these changes Apr 24, 2023
View reviewed changes
twilight-model/src/channel/attachment.rs Outdated Show resolved Hide resolved
@itohatweb itohatweb self-requested a review April 24, 2023 13:27
@itohatweb itohatweb dismissed their stale review April 24, 2023 13:27

Might wanna change waveform to be decoded automatically.

Gelbpunkt
Gelbpunkt approved these changes Apr 24, 2023
View reviewed changes
Copy link
Member

@Gelbpunkt Gelbpunkt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I don't think twilight should decode the base64. It is a very niche usecase, adds a new dependency in model and the only benefit would probably be for the cache (memory savings), but users who care about that should look at #2179

@itohatweb itohatweb added this pull request to the merge queue Apr 24, 2023
Merged via the queue into twilight-rs:main with commit 135bd73 Apr 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@laralove143 laralove143 laralove143 left review comments

@vilgotf vilgotf vilgotf approved these changes

@Gelbpunkt Gelbpunkt Gelbpunkt approved these changes

@itohatweb itohatweb itohatweb approved these changes

Assignees

@suneettipirneni suneettipirneni

Labels
c-cache Affects the cache crate c-model Affects the model crate t-feature Addition of a new feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@suneettipirneni @vilgotf @Gelbpunkt @itohatweb @laralove143