Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable reporting of encoding warnings. #578

Merged
merged 4 commits into from
Apr 28, 2024

Conversation

jaraco
Copy link
Contributor

@jaraco jaraco commented Feb 10, 2024

Description

As suggested in #561 and #577, enable reporting of EncodingWarnings per PEP 597.

This PR is proposed separately from #577, because #577 only fixes the warnings in the main codebase and not in the tests. 80-some warnings remain to be addressed, so I leave it to the maintainers to determine when to add this check.

Checklist

  • Make sure changes are covered by existing or new tests.
  • For at least one Python version, make sure local test run is green.
  • Create a file in src/towncrier/newsfragments/. Describe your
    change and include important information. Your change will be included in the public release notes.
  • Make sure all GitHub Actions checks are green (they are automatically checking all of the above).
  • Ensure docs/tutorial.rst is still up-to-date.
  • If you add new CLI arguments (or change the meaning of existing ones), make sure docs/cli.rst reflects those changes.
  • If you add new configuration options (or change the meaning of existing ones), make sure docs/configuration.rst reflects those changes.

@jaraco jaraco requested a review from a team as a code owner February 10, 2024 17:06
@adiroiban
Copy link
Member

Thansk for the PR... sorry for missing it.

Feel free to ping me if a PR is not reviewed.

I sent invitation to you and @SmileyChris to towncrier contributors team... if a PR is approved, you can trigger the merge.

Copy link
Member

@adiroiban adiroiban left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

We can have it merged.

The current change will not do much in our CI... but I hope that it will make problem more visible to the current dev team :)

I think that this is something that we might to have in trial.

Trial should capture the warnings and fail on warnings

@adiroiban adiroiban enabled auto-merge (squash) April 28, 2024 12:19
@adiroiban adiroiban merged commit f6083bb into twisted:trunk Apr 28, 2024
15 checks passed
@adiroiban
Copy link
Member

I have enabled auto-merge for this. I hope it will land soon. Thanks again!

@jaraco jaraco deleted the tests/encoding-warnings branch April 28, 2024 18:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants