This repository has been archived by the owner on Sep 18, 2021. It is now read-only.
Move Hash symbolize_keys/symbolize_keys! to a helper module. #90
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Implement symbolize_keys and symbolize_keys! as a helper (HashHelper), avoiding conflicts with projects stuck with old activerecord (~> 2.3.18) and/or old Rails (2).
|
This looks good to me, thanks. |
jakl
added a commit
that referenced
this pull request
Apr 17, 2013
Move Hash symbolize_keys/symbolize_keys! to a helper module.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just wanted to start a discussion/issue, figured out it'd be easier showing some code, hope that is OK.
The issue happens when trying to add twitter-text-rb as a dependency of an application where old activerecord (e.g. 2.3.18) is also a dependency (e.g. Rails 2 app).
activerecord 2, the
Hashsymbolize_keys method used to return a newHash, andHashWithIndifferentAccessrelied on that behavior (it doesn't overwrite that method).With the current
lib/twitter-text/core_ext/hashextension,HashWithIndifferentAccess#symbolize_keysreturns a newHashWithIndifferentAccessinstead, which can cause unexpected behavior (e.g.HashWithIndifferentAccess.new('test' => 1).symbolize_keys.each { |k, v| puts k; }returns strings as keys instead of symbols).I know it's a corner case, but it'd be nice for people still stuck with old activerecord (~> 2.3.18) and/or old Rails (2).