Use temporary files, instead of stdin/stdout, when calling gpg #1229
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
twpayne
force-pushed
the
gpg-temp-files
branch
2 times, most recently
from
4b2f7fc
to
d858159
Compare
|
Merging this as there's a small performance impact but it should fix stuff. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refs #1074.
@3v1n0 would you be able to test if this PR fixes the problems you reported in #1074?
It changes the way that chezmoi reads and writes data from gpg back to how it was done prior to chezmoi v2, i.e it reverts back to using temporary files rather than gpg's standard input and output.