Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Combine coverage profiles for more accurate coverage #236

Merged
merged 1 commit into from
Mar 24, 2019

Conversation

twpayne
Copy link
Owner

@twpayne twpayne commented Mar 24, 2019

No description provided.

@twpayne twpayne merged commit 107b579 into master Mar 24, 2019
@twpayne twpayne deleted the better-coverage branch March 24, 2019 15:59
@twpayne
Copy link
Owner Author

twpayne commented Mar 24, 2019

@stapelberg FYI this is how to combine Go coverage profiles to get overall coverage across multiple packages.

@stapelberg
Copy link
Contributor

stapelberg commented Mar 24, 2019 via email

@twpayne
Copy link
Owner Author

twpayne commented Mar 24, 2019

Fair question. I saw a 7% increase in code coverage as reported by coveralls.io when I switched to merging the cover profiles in this PR, but maybe I did something wrong or my understanding is incorrect. Let me investigate.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 16, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants