chore: Simplify code by using strings.EqualFold, time.Before #3038
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the explanation @twpayne! I hope my comment didn't discourage @alexandear, it certainly wasn't my intention. |
renovate bot
added a commit
to scottames/dots
that referenced
this pull request
Jun 17, 2023
[](https://renovatebot.com) This PR contains the following updates: | Package | Update | Change | |---|---|---| | [aquaproj/aqua-registry](https://togithub.com/aquaproj/aqua-registry) | minor | `v4.18.0` -> `v4.19.0` | | [golangci/golangci-lint](https://togithub.com/golangci/golangci-lint) | patch | `v1.53.2` -> `v1.53.3` | | [helm/helm](https://togithub.com/helm/helm) | patch | `v3.12.0` -> `v3.12.1` | | [junegunn/fzf](https://togithub.com/junegunn/fzf) | minor | `0.41.1` -> `0.42.0` | | [kubernetes/kubectl](https://togithub.com/kubernetes/kubectl) | patch | `1.27.2` -> `1.27.3` | | [twistedpair/google-cloud-sdk](https://togithub.com/twistedpair/google-cloud-sdk) | patch | `435.0.0` -> `435.0.1` | | [twpayne/chezmoi](https://togithub.com/twpayne/chezmoi) | patch | `v2.34.1` -> `v2.34.2` | | [weaveworks/eksctl](https://togithub.com/weaveworks/eksctl) | minor | `v0.144.0` -> `v0.145.0` | --- ### Release Notes <details> <summary>aquaproj/aqua-registry</summary> ### [`v4.19.0`](https://togithub.com/aquaproj/aqua-registry/releases/tag/v4.19.0) [Compare Source](https://togithub.com/aquaproj/aqua-registry/compare/v4.18.0...v4.19.0) [Issues](https://togithub.com/aquaproj/aqua-registry/issues?q=is%3Aissue+milestone%3Av4.19.0) | [Pull Requests](https://togithub.com/aquaproj/aqua-registry/pulls?q=is%3Apr+milestone%3Av4.19.0) | aquaproj/aqua-registry@v4.18.0...v4.19.0 ##### 🎉 New Packages [#​13100](https://togithub.com/aquaproj/aqua-registry/issues/13100) [daixiang0/gci](https://togithub.com/daixiang0/gci): GCI, a tool that control golang package import order and make it always deterministic [@​iwata](https://togithub.com/iwata) [#​13100](https://togithub.com/aquaproj/aqua-registry/issues/13100) [cloudspannerecosystem/spool](https://togithub.com/cloudspannerecosystem/spool): Manage Cloud Spanner databases for testing [@​iwata](https://togithub.com/iwata) [#​13100](https://togithub.com/aquaproj/aqua-registry/issues/13100) [apstndb/execspansql](https://togithub.com/apstndb/execspansql): Yet another gcloud spanner databases execute-sql replacement for better composability [@​iwata](https://togithub.com/iwata) [#​13100](https://togithub.com/aquaproj/aqua-registry/issues/13100) [apstndb/spannerplanviz/rendertree](https://togithub.com/apstndb/spannerplanviz/tree/master/cmd/rendertree): Render YAML or JSON representation of Cloud Spanner query plan as ascii format [@​iwata](https://togithub.com/iwata) [#​13100](https://togithub.com/aquaproj/aqua-registry/issues/13100) [sanposhiho/gomockhandler](https://togithub.com/sanposhiho/gomockhandler): Clever and more agile manager of golang/mock [@​iwata](https://togithub.com/iwata) ##### 🎉 New Contributors Thank you for your contribution! [@​iwata](https://togithub.com/iwata) [#​13100](https://togithub.com/aquaproj/aqua-registry/issues/13100) </details> <details> <summary>golangci/golangci-lint</summary> ### [`v1.53.3`](https://togithub.com/golangci/golangci-lint/blob/HEAD/CHANGELOG.md#v1533) [Compare Source](https://togithub.com/golangci/golangci-lint/compare/v1.53.2...v1.53.3) 1. updated linters: - `cyclop`: from 1.2.0 to 1.2.1 - `exhaustive`: from 0.10.0 to 0.11.0 - `forbidigo`: from 1.5.1 to 1.5.3 - `ginkgolinter`: from 0.12.2 to 0.12.1 - `ineffassign`: bump to HEAD - `nakedret`: from 2.0.1 to 2.0.2 - `zerologlint`: from 0.1.1 to 0.1.2 2. misc. - codeclimate: reduce memory allocation - support illumos/amd64 </details> <details> <summary>helm/helm</summary> ### [`v3.12.1`](https://togithub.com/helm/helm/releases/tag/v3.12.1): Helm v3.12.1 [Compare Source](https://togithub.com/helm/helm/compare/v3.12.0...v3.12.1) Helm v3.12.1 is a patch release. Users are encouraged to upgrade for the best experience. Users are encouraged to upgrade for the best experience. The community keeps growing, and we'd love to see you there! - Join the discussion in [Kubernetes Slack](https://kubernetes.slack.com): - for questions and just to hang out - for discussing PRs, code, and bugs - Hang out at the Public Developer Call: Thursday, 9:30 Pacific via [Zoom](https://zoom.us/j/696660622) - Test, debug, and contribute charts: [ArtifactHub/packages](https://artifacthub.io/packages/search?kind=0) #### Installation and Upgrading Download Helm v3.12.1. The common platform binaries are here: - [MacOS amd64](https://get.helm.sh/helm-v3.12.1-darwin-amd64.tar.gz) ([checksum](https://get.helm.sh/helm-v3.12.1-darwin-amd64.tar.gz.sha256sum) / f487b5d8132bd2091378258a3029e33ee10f71575b2167cdfeaf6d0144d20938) - [MacOS arm64](https://get.helm.sh/helm-v3.12.1-darwin-arm64.tar.gz) ([checksum](https://get.helm.sh/helm-v3.12.1-darwin-arm64.tar.gz.sha256sum) / e82e0433589b1b5170807d6fec75baedba40620458510bbd30cdb9d2246415fe) - [Linux amd64](https://get.helm.sh/helm-v3.12.1-linux-amd64.tar.gz) ([checksum](https://get.helm.sh/helm-v3.12.1-linux-amd64.tar.gz.sha256sum) / 1a7074f58ef7190f74ce6db5db0b70e355a655e2013c4d5db2317e63fa9e3dea) - [Linux arm](https://get.helm.sh/helm-v3.12.1-linux-arm.tar.gz) ([checksum](https://get.helm.sh/helm-v3.12.1-linux-arm.tar.gz.sha256sum) / 6ae6d1cb3b9f7faf68d5cd327eaa53c432f01e8fd67edba4e4c744dcbd8a0883) - [Linux arm64](https://get.helm.sh/helm-v3.12.1-linux-arm64.tar.gz) ([checksum](https://get.helm.sh/helm-v3.12.1-linux-arm64.tar.gz.sha256sum) / 50548d4fedef9d8d01d1ed5a2dd5c849271d1017127417dc4c7ef6777ae68f7e) - [Linux i386](https://get.helm.sh/helm-v3.12.1-linux-386.tar.gz) ([checksum](https://get.helm.sh/helm-v3.12.1-linux-386.tar.gz.sha256sum) / 983addced237a8eb921c2c8c953310d92031a6ce4599632edbe7cdb2c95a701e) - [Linux ppc64le](https://get.helm.sh/helm-v3.12.1-linux-ppc64le.tar.gz) ([checksum](https://get.helm.sh/helm-v3.12.1-linux-ppc64le.tar.gz.sha256sum) / 32b25dba14549a4097bf3dd62221cf6df06279ded391f7479144e3a215982aaf) - [Linux s390x](https://get.helm.sh/helm-v3.12.1-linux-s390x.tar.gz) ([checksum](https://get.helm.sh/helm-v3.12.1-linux-s390x.tar.gz.sha256sum) / f243b564cf7e4081fffdfe5a39487f6442fc439586a1f50cc59dd801c3e636a5) - [Windows amd64](https://get.helm.sh/helm-v3.12.1-windows-amd64.zip) ([checksum](https://get.helm.sh/helm-v3.12.1-windows-amd64.zip.sha256sum) / 9040f8f37c90600a51db4934c04bc9c2adc058cb2161e20b5193b3ba46de10fa) This release was signed with ` 672C 657B E06B 4B30 969C 4A57 4614 49C2 5E36 B98E ` and can be found at [@​mattfarina](https://togithub.com/mattfarina) [keybase account](https://keybase.io/mattfarina). Please use the attached signatures for verifying this release using `gpg`. The [Quickstart Guide](https://helm.sh/docs/intro/quickstart/) will get you going from there. For **upgrade instructions** or detailed installation notes, check the [install guide](https://helm.sh/docs/intro/install/). You can also use a [script to install](https://raw.githubusercontent.com/helm/helm/main/scripts/get-helm-3) on any system with `bash`. #### What's Next - 3.12.2 is the next patch/bug fix release and will be on July 12, 2023. - 3.13.0 is the next feature release and be on September 13, 2023. #### Changelog - add some test case [`f32a527`](https://togithub.com/helm/helm/commit/f32a527a060157990e2aa86bf45010dfb3cc8b8d) (wujunwei) - fix comment grammar error. [`91bb1e3`](https://togithub.com/helm/helm/commit/91bb1e34e605a2bfc3fbc4de14921e071af84fd7) (wujunwei) - bugfix:([#​11391](https://togithub.com/helm/helm/issues/11391)) helm lint infinite loop when malformed template object [`5217482`](https://togithub.com/helm/helm/commit/5217482c8eab1b44cc07dfcfd669c6ee47f3b9bc) (wujunwei) - chore(deps): bump github.com/opencontainers/runc from 1.1.4 to 1.1.5 [`524a0e7`](https://togithub.com/helm/helm/commit/524a0e745742ebda08fbf8965c2c45587a51ae54) (dependabot\[bot]) - chore(deps): bump github.com/docker/distribution [`c60cdf6`](https://togithub.com/helm/helm/commit/c60cdf62ab447ba056e75b5e9d82dd2e2843315a) (dependabot\[bot]) - update autoscaling/v2beta1 to autoscaling/v2 in skeleton chart [`321f71a`](https://togithub.com/helm/helm/commit/321f71a161706c1184604602408b05fe0097f6eb) (Dmitry Kamenskikh) - test(search): add mixedCase test case [`aca1e44`](https://togithub.com/helm/helm/commit/aca1e44f64b46a0946e526eeb08e983bf575560d) (Höhl, Lukas) - chore(deps): bump github.com/lib/pq from 1.10.7 to 1.10.9 [`c09e93f`](https://togithub.com/helm/helm/commit/c09e93f82fec544e28a2972b8c06c37441503013) (dependabot\[bot]) - chore(deps): bump github.com/Masterminds/squirrel from 1.5.3 to 1.5.4 [`8eab82b`](https://togithub.com/helm/helm/commit/8eab82b0fabe0305d815d352180f0b551fc6c6da) (dependabot\[bot]) - chore(deps): bump github.com/Masterminds/semver/v3 from 3.2.0 to 3.2.1 [`aa6b8aa`](https://togithub.com/helm/helm/commit/aa6b8aa0298cab0f7664a00cd32454f1738239ed) (dependabot\[bot]) - fix(search): print repo search result in original case [`5b19d8e`](https://togithub.com/helm/helm/commit/5b19d8eedb24691a035f1d1f1d42cb0cdde97813) (Höhl, Lukas) - strict file permissions of repository.yaml [`dee1fde`](https://togithub.com/helm/helm/commit/dee1fde4e821e056a27bebc488cb36f22b322404) (shankeerthan-kasilingam) - update kubernetes dependencies from v0.27.0 to v0.27.1 [`4f32150`](https://togithub.com/helm/helm/commit/4f32150a3f55b920971c0189febc8101f11be630) (Joe Julian) </details> <details> <summary>junegunn/fzf</summary> ### [`v0.42.0`](https://togithub.com/junegunn/fzf/blob/HEAD/CHANGELOG.md#​0420) [Compare Source](https://togithub.com/junegunn/fzf/compare/0.41.1...0.42.0) - Added new info style: `--info=right` - Added new info style: `--info=inline-right` - Added new border style `thinblock` which uses symbols for legacy computing [one eighth block elements](https://en.wikipedia.org/wiki/Symbols_for_Legacy_Computing) - Similarly to `block`, this style is suitable when using a different background color because the window is completely contained within the border. ```sh BAT_THEME=GitHub fzf --info=right --border=thinblock --preview-window=border-thinblock \ --margin=3 --scrollbar=▏▕ --preview='bat --color=always --style=numbers {}' \ --color=light,query:238,fg:238,bg:251,bg+:249,gutter:251,border:248,preview-bg:253 ``` - This style may not render correctly depending on the font and the terminal emulator. </details> <details> <summary>kubernetes/kubectl</summary> ### [`v1.27.3`](https://togithub.com/kubernetes/kubectl/compare/kubernetes-1.27.2...kubernetes-1.27.3) [Compare Source](https://togithub.com/kubernetes/kubectl/compare/kubernetes-1.27.2...kubernetes-1.27.3) </details> <details> <summary>twistedpair/google-cloud-sdk</summary> ### [`v435.0.1`](https://togithub.com/twistedpair/google-cloud-sdk/compare/435.0.0...435.0.1) [Compare Source](https://togithub.com/twistedpair/google-cloud-sdk/compare/435.0.0...435.0.1) </details> <details> <summary>twpayne/chezmoi</summary> ### [`v2.34.2`](https://togithub.com/twpayne/chezmoi/releases/tag/v2.34.2) [Compare Source](https://togithub.com/twpayne/chezmoi/compare/v2.34.1...v2.34.2) #### What's Changed - chore: Simplify code by using strings.EqualFold, time.Before by [@​twpayne](https://togithub.com/twpayne) in [twpayne/chezmoi#3038 - chore: Use http.NoBody instead of nil by [@​alexandear](https://togithub.com/alexandear) in [twpayne/chezmoi#3040 - chore: Miscellaneous clean-ups by [@​twpayne](https://togithub.com/twpayne) in [twpayne/chezmoi#3041 - fix: Handle multiple files in .chezmoidata directory by [@​twpayne](https://togithub.com/twpayne) in [twpayne/chezmoi#3042 - chore: Update dependencies by [@​twpayne](https://togithub.com/twpayne) in [twpayne/chezmoi#3043 - chore(deps): bump golangci/golangci-lint-action from 3.4.0 to 3.6.0 by [@​dependabot](https://togithub.com/dependabot) in [twpayne/chezmoi#3044 - chore(deps): bump dessant/lock-threads from 4.0.0 to 4.0.1 by [@​dependabot](https://togithub.com/dependabot) in [twpayne/chezmoi#3045 - chore(deps): bump github/codeql-action from 2.3.5 to 2.20.0 by [@​dependabot](https://togithub.com/dependabot) in [twpayne/chezmoi#3046 - chore(deps): bump goreleaser/goreleaser-action from 4.2.0 to 4.3.0 by [@​dependabot](https://togithub.com/dependabot) in [twpayne/chezmoi#3047 - chore(deps): bump actions/checkout from 3.5.2 to 3.5.3 by [@​dependabot](https://togithub.com/dependabot) in [twpayne/chezmoi#3048 **Full Changelog**: twpayne/chezmoi@v2.34.1...v2.34.2 </details> <details> <summary>weaveworks/eksctl</summary> ### [`v0.145.0`](https://togithub.com/weaveworks/eksctl/releases/tag/v0.145.0): eksctl 0.145.0 (permalink) [Compare Source](https://togithub.com/weaveworks/eksctl/compare/0.144.0...0.145.0) ### Release v0.145.0 #### 🚀 Features - Make the output stream for eksctl command configurable ([#​6675](https://togithub.com/weaveworks/eksctl/issues/6675)) #### 🎯 Improvements - Updated wellKnownPolicy for Cluster Autoscaler and LoadBalancer Controller ([#​6667](https://togithub.com/weaveworks/eksctl/issues/6667)) - Add integration tests for resource-based hostnames ([#​6659](https://togithub.com/weaveworks/eksctl/issues/6659)) #### 🧰 Maintenance - Bump dependencies ([#​6674](https://togithub.com/weaveworks/eksctl/issues/6674)) #### Acknowledgments Weaveworks would like to sincerely thank: [@​hassaanakram](https://togithub.com/hassaanakram) and [@​joneidaws](https://togithub.com/joneidaws) </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled because a matching PR was automerged previously. ♻ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox. 👻 **Immortal**: This PR will be recreated if closed unmerged. Get [config help](https://togithub.com/renovatebot/renovate/discussions) if that's undesired. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/scottames/dots). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNS4xMTcuMyIsInVwZGF0ZWRJblZlciI6IjM1LjExNy4zIiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
](https://renovatebot.com){kind=link}
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Re-opens #3034. The original branch was deleted so I couldn't simply re-open the original PR.
Thanks for this @alexandear!
@bradenhilton was right in #3034 (comment) that this subtly changes the semantics of refresh periods, but refresh periods are more guidelines than rules and as Go records timestamps in nanoseconds, the chances of hitting this are minuscule and it wouldn't matter anyway.