Statically link Linux binary with musl #893
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
twpayne
force-pushed
the
static-link-with-musl
branch
from
0ee7044
to
ca23287
Compare
Legion2
reviewed
Sep 28, 2020
.github/workflows/main.yml
Outdated
| @@ -62,7 +65,7 @@ jobs: | |||
| - name: Test release | |||
| run: | | |||
| # verify that version information is embedded correctly | |||
| ./dist/chezmoi-cgo_linux_amd64/chezmoi --version | tee /dev/stderr | grep -q "chezmoi version v" | |||
| file ./dist/chezmoi-cgo_linux_amd64/chezmoi --version | tee /dev/stderr | grep -q "statically linked" | |||
There was a problem hiding this comment.
Suggested change
| file ./dist/chezmoi-cgo_linux_amd64/chezmoi --version | tee /dev/stderr | grep -q "statically linked" | |
| file ./dist/chezmoi-cgo_linux_amd64/chezmoi | tee /dev/stderr | grep -q "statically linked" |
There was a problem hiding this comment.
Good catch, thanks! I was a bit sloppy with cut-and-paste.
twpayne
force-pushed
the
static-link-with-musl
branch
from
8c864ea
to
c04022b
Compare
This was referenced Oct 7, 2020
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #892.