Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Slightly optimize Monad.pure for Stream #2099

Merged
merged 1 commit into from
Oct 22, 2020
Merged

Slightly optimize Monad.pure for Stream #2099

merged 1 commit into from
Oct 22, 2020

Conversation

satorg
Copy link
Contributor

@satorg satorg commented Oct 22, 2020

Leverage Stream.emit in Monad.pure implementation instead of Stream.apply (which always takes Seq).
Conversation it here

@satorg
Copy link
Contributor Author

satorg commented Oct 22, 2020

I am uncertain though to which branch it is better to PR. If main is a wrong branch, I can rebase this "fix".

kubukoz
kubukoz approved these changes Oct 22, 2020
View reviewed changes
Copy link
Member

@kubukoz kubukoz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this belongs in main, but it should land on develop (fs2 3.x) as well 👍

Thanks!

@mpilquist mpilquist merged commit 6aecba0 into typelevel:main Oct 22, 2020
@satorg satorg deleted the smallopt-stream-monad-pure branch October 22, 2020 17:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kubukoz kubukoz kubukoz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@satorg @kubukoz @mpilquist