Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose Exception caused by not using X509ExtendedTrustManager #2431

Merged
merged 4 commits into from
Jun 4, 2021

Conversation

hamnis
Copy link
Contributor

@hamnis hamnis commented Jun 3, 2021

Adds a failing test with fix.

https://bugs.openjdk.java.net/browse/JDK-8242183

On JDK 11.0.2 this will fail with a NullPointerException.
After a fix in https://bugs.openjdk.java.net/browse/JDK-8242183 this now
causes a CertificateException.

The "fix" is to always use an X509ExtendedTrustManager.
@mpilquist mpilquist merged commit 970de25 into typelevel:main Jun 4, 2021
@hamnis hamnis deleted the insecure-tlscontext branch June 4, 2021 17:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants