Fix the cross-platform time arbitraries, again #889
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rossabaker
approved these changes
Apr 9, 2022
|
It's not particularly critical. I was really hoping to get the I'm not sure what the versioning rules are for scalacheck. E.g. in Cats(-Effect) new features are only added in minor bumps and patches are only for bugs, in which case this can't go into a patch. |
|
You're right according to strict semantic versioning, even if it feels patchy. If you're not begging for a release, we could bundle it with anything else that gets reviewed in the next couple weeks as 1.17. |
|
Nobody objected. We've got a motivating change coming through. Let's ship it and call it 1.17. |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Re-does:
java.timearbitraries on Scala.js & Native #830Between the sbt-typelevel migration, the botched merge, and my blind fury to publish for Native on Scala 3, this slipped through the cracks again. Oh well.