Do not silently ignore catastrophic problem

Co-authored-by: Werner Dietl <wdietl@gmail.com>
typetools · Mar 15, 2024 · 38a69dd · 38a69dd
1 parent acf0fea
commit 38a69dd
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 5 deletions.
diff --git a/javacutil/src/main/java/org/checkerframework/javacutil/ElementUtils.java b/javacutil/src/main/java/org/checkerframework/javacutil/ElementUtils.java
@@ -1091,10 +1091,6 @@ public static List<? extends Element> getRecordComponents(TypeElement element) {
    * @return true if the element is a compact canonical constructor of a record
    */
   public static boolean isCompactCanonicalRecordConstructor(Element elt) {
-    if (!(elt instanceof Symbol)) {
-      return false;
-    }
-
     return elt.getKind() == ElementKind.CONSTRUCTOR
         && (((Symbol) elt).flags() & Flags_COMPACT_RECORD_CONSTRUCTOR) != 0;
   }

diff --git a/javacutil/src/main/java/org/checkerframework/javacutil/TreeUtils.java b/javacutil/src/main/java/org/checkerframework/javacutil/TreeUtils.java
@@ -1734,7 +1734,11 @@ public static boolean isCompactCanonicalRecordConstructor(MethodTree method) {
    */
   public static boolean isAutoGeneratedRecordMember(Tree member) {
     Element e = elementFromTree(member);
-    return e != null && ElementUtils.isAutoGeneratedRecordMember(e);
+    if (e == null) {
+      throw new BugInCF(
+          "TreeUtils.isAutoGeneratedRecordMember: null element for member tree: " + member);
+    }
+    return ElementUtils.isAutoGeneratedRecordMember(e);
   }
 
   /**