Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The Daily Beast #22

Open
Yoshiofthewire opened this issue Oct 4, 2014 · 1 comment
Open

The Daily Beast #22

Yoshiofthewire opened this issue Oct 4, 2014 · 1 comment

Comments

@Yoshiofthewire
Copy link

Ad detector says everything on the Daily Beast is an Ad.
http://www.thedailybeast.com/

Ad For Ebola
@kmeisthax
Copy link
Contributor

Pull request #24 fixes this by restricting all Daily Beast selectors to the first loaded article.

What's happening here is that Daily Beast is using infinite scroll now, and with the way the rules are currently configured, any article which is sponsored causes AdDetector to warn about advertising across the whole page, pulling the sponsor from the first sponsored article. Also the sponsor detection isn't useful anymore.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@kmeisthax @Yoshiofthewire