Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keep Daily Beast from warning about infinite-scroll-loaded articles. #24

Merged
merged 1 commit into from
Oct 31, 2014

Conversation

kmeisthax
Copy link
Contributor

The sponsor detection is probably worthless at this point - the example I uploaded is sponsored by Lenovo, but it uses the category name as the sponsor, even though that category has both articles and native advertising. The original example disclosed the sponsor in the category, but the new example doesn't. In fact, for Lenovo ads, the only consistent thing I could see is that there's a Lenovo logo in there, but it's an image with alt tag "lenovo-inline-from", which is inconsistently placed, and not a reliable method of sponsor detection.

Also, this is a bit of a hack, in that we're intentionally silencing warnings about infinitely-scrolled content. The underlying issue is that when you request a page from Daily Beast, they're actually loading three or four other articles which may or may not be native advertising. I do not believe we have APIs for this.

@kmeisthax kmeisthax mentioned this pull request Oct 11, 2014
@typpo typpo merged commit 4b5854c into typpo:master Oct 31, 2014
@mldangelo
Copy link
Sponsor Collaborator

Thanks so much kmeisthax for fixing this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants