Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: Safari version #5

Open
m4p opened this issue Aug 16, 2014 · 5 comments
Open

Feature request: Safari version #5

m4p opened this issue Aug 16, 2014 · 5 comments

Comments

@m4p
Copy link

m4p commented Aug 16, 2014

Are there plans to add a Safari Plugin as well?

@Zegnat
Copy link

Zegnat commented Aug 17, 2014

You can grab the Safari extension from my fork if you want to help me test it. It is pretty straight forward, but there seems do be an odd bug in effect that doesn’t always render the warning so I am not filing a pull request yet.

Screen shot comparing The New York Times with Forbes, the latter does not display the AdDetector alert.

@kleinmaetschke
Copy link

While appreciated, @Zegnat, your extension doesn't seem to work. The request for @typpo to integrate it should stay.

@mnanda
Copy link

mnanda commented Oct 19, 2014

Ditto. Can't find Safari extension to download, just an info.plist and icons. Sarafi extension would be GREAT! Thanks.

@Zegnat
Copy link

Zegnat commented Oct 20, 2014

Can’t find Safari extension to download, just an info.plist and icons.

My fork is very bare-bones, you will have to follow the instructions for running from source and then add the safari.safariextension folder through your extension builder.

But Ad-Detector has grown quiet a bit since I forked it so I should probably do a complete rebasing. I might have time freeing up again next week and if @typpo has not taken any steps towards Safari himself I can have another go at it then.

@mnanda
Copy link

mnanda commented Oct 20, 2014

Wow Martijin, thank you. I'm not a coder, just a girl who hates
advertising. If you update it, I'll post about it in the comments on
Lifehacker.com

Best regards.

Amanda

On Mon, Oct 20, 2014 at 5:01 AM, Martijn van der Ven <
notifications@github.com> wrote:

Can’t find Safari extension to download, just an info.plist and icons.

My fork is very bare-bones, you will have to follow the instructions for running
from source https://github.com/Zegnat/ad-detector#running-from-source
and then add the safari.safariextension folder through your extension
builder.

But Ad-Detector has grown quiet a bit since I forked it so I should
probably do a complete rebasing. I might have time freeing up again next
week and if @typpo https://github.com/typpo has not taken any steps
towards Safari himself I can have another go at it then.


Reply to this email directly or view it on GitHub
#5 (comment).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants