Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix typo in README.md #409

Merged
merged 1 commit into from
Nov 1, 2017
Merged

Fix typo in README.md #409

merged 1 commit into from
Nov 1, 2017

Conversation

Atalanttore
Copy link
Contributor

@Atalanttore Atalanttore commented Nov 1, 2017 •
edited
Loading

README: Add space before parenthesis.

paulmenzel
paulmenzel reviewed Nov 1, 2017
View reviewed changes
Copy link

@paulmenzel paulmenzel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use imperative mood in commit messages, so Fix instead of Fixed. A more descriptive comment would also be nice, like README: Add space before parenthesis.

paulmenzel
paulmenzel approved these changes Nov 1, 2017
View reviewed changes
Copy link

@paulmenzel paulmenzel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It’d be great if you could update the commit and pull request, but if not, this shouldn’t block it from going in either.

@Atalanttore Atalanttore changed the title Fixed typo in README.md Fix typo in README.md Nov 1, 2017
@Atalanttore
Copy link
Contributor Author

Updated.

@paulmenzel paulmenzel merged commit a2f86f5 into u-root:master Nov 1, 2017
@Atalanttore Atalanttore deleted the patch-1 branch November 1, 2017 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paulmenzel paulmenzel paulmenzel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Atalanttore @paulmenzel