Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add setting to not use RLRQ and RLRE #78

Closed
Krolken opened this issue Feb 26, 2024 · 0 comments · Fixed by #80
Closed

Add setting to not use RLRQ and RLRE #78

Krolken opened this issue Feb 26, 2024 · 0 comments · Fixed by #80
Assignees

Comments

@Krolken
Copy link
Contributor

Krolken commented Feb 26, 2024

It is possible for device to not use ReleaseRequest and ReleaseResonse.

Before this was handled by customizing the client, but since we now Have the DlmsConnectionSetting-object it would be better to put it there.

Example:

@attr.s(auto_attribs=True)
class DlmsConnectionSettings:
    """
    Class to hold values and settings to handle different quirks of different dlms
    server implementations and manufacturers specific irregularity.
    """
    # Indicates if the connection and the client should allow for RLRQ to be send.
    use_rlrq_rlre: bool = attr.ib(default=True)
    # In Pietro Fiorentini local communication over HDLC the system title in GeneralGlobalCiphering is omitted.
    empty_system_title_in_general_glo_ciphering: bool = attr.ib(default=False)
@Krolken Krolken self-assigned this Feb 26, 2024
Krolken pushed a commit that referenced this issue Feb 26, 2024
Some devices does not use the ReleaseRequest and ReleaseResponse to release an association and the lower layer can be disconnecter right away.
Implementing the new setting, how it handled in the connection and in the client.

Fixes #78
Krolken added a commit that referenced this issue Feb 26, 2024
* feat(connection): Added use_rlrq_rlre on DlmsConnectionSetting

Some devices does not use the ReleaseRequest and ReleaseResponse to release an association and the lower layer can be disconnecter right away.
Implementing the new setting, how it handled in the connection and in the client.

Fixes #78

-- Smal fixes to CI.

---------

Co-authored-by: Henrik Wahlgren <henrik.wahlgren@utilitarian.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant