Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

msn.com: ads #2215

Closed
8 tasks done
grfxwzdesigner opened this issue Aug 13, 2022 · 11 comments
Closed
8 tasks done

msn.com: ads #2215

grfxwzdesigner opened this issue Aug 13, 2022 · 11 comments
Labels
invalid not a uBlock issue unable to reproduce cannot reproduce the issue

Comments

@grfxwzdesigner
Copy link

Prerequisites

  • I read and understood the policy as to what is a valid filter issue
  • I verified that the issue has not already been reported (use this button to find out)
  • I forced an update of my filter lists (how to do this: click "Purge all caches", then click "Update now")
  • I did not remove any of the default filter lists, or I verified that the issue is not caused by removing any of the default lists
  • I did not enable external filter lists, or I verified that the issue still occurs without enabling external filter lists
  • I do not have custom filters/rules, or I verified that the issue still occurs without custom filters/rules
  • I am not using another content blocker along uBO (also mind browser built-in blockers)
  • I did not answer truthfully to all the above checkpoints

URL address of the web page

https://www.msn.com/

Category

ads -

Describe the issue

areas I have blocked are now appearing and the elemnt picker and element zapper are no tworking. When I try to use them the entire page is highlighted.

Screenshot(s)

Screenshot(s)

Configuration

uBlock Origin: 1.43.0
Firefox: 103
filterset (summary): 
  network: 80464
  cosmetic: 45315
  scriptlet: 17620
  html: 725
listset (total-discarded, last updated): 
  default: 
    user-filters: 27-3, never
    ublock-filters: 33157-38, 22m
    ublock-badware: 4180-0, 4d.6m
    ublock-privacy: 247-0, 2d.16h.2m
    ublock-abuse: 76-0, 2d.16h.3m
    ublock-unbreak: 1867-0, 20m
    easylist: 69419-591, 21m
    easyprivacy: 27333-581, 23m
    urlhaus-1: 5190-0, 1d.4m
    plowe-0: 3639-3, 12d.18h.27m
    ublock-quick-fixes: 376-1, 21h.23m
filterset (user): [array of 27 redacted]
trustedset: 
  added: [array of 5 redacted]
modifiedUserSettings: [none]
modifiedHiddenSettings: [none]
supportStats: 
  allReadyAfter: 688 ms (selfie)
  maxAssetCacheWait: 427 ms
popupPanel: 
  blocked: 29
  blockedDetails: 
    msn.com: 14
    azure.com: 2
    btloader.com: 3
    microsoft.com: 7
    scorecardresearch.com: 1
    yahoo.com: 2
@Yuki2718 Yuki2718 added the unable to reproduce cannot reproduce the issue label Aug 13, 2022
@Yuki2718
Copy link

Screenshot?

@Yuki2718
Copy link

areas I have blocked are now appearing and the elemnt picker and element zapper are no tworking. When I try to use them the entire page is highlighted.

We only address filtering issue by default lists here. If this comment is all your problem, it's for reddit forum.

@grfxwzdesigner
Copy link
Author

I cleared my cache and cookies last night and the problem went away, but this morning the problem returned. I tried clearing cache and cookies again but this time it did not work, so I did a restore to last night before I shut the pc down and that did not help either. The problem also exists in Chrome. PLEASE help!

@okiehsch
Copy link

areas I have blocked are now appearing and the elemnt picker and element zapper are no tworking. When I try to use them the entire page is highlighted.

Well, it's not a filter issue and I can't reproduce using Chrome.
I will transfer the issue to https://github.com/uBlockOrigin/uBlock-issues

@okiehsch okiehsch transferred this issue from uBlockOrigin/uAssets Aug 15, 2022
@gorhill
Copy link
Member

gorhill commented Aug 15, 2022

areas I have blocked

Your description is too vague, there is nothing for me to investigate. Be very specific, provide details about which filter is not working on which exact page (provide URL address) which you say should be working, otherwise I will close as invalid.

@JohnyP36
Copy link

I think it has to do with the fact that MSN uses #shadow-root to display recommended articles below an articles. Between the blocks with articles are blocks with ads. But because the network requests are blocked those blocks will appear as black.

https://www.msn.com/nl-nl/gezondheid/medisch/rutte-wil-een-euro-op-de-melkprijs/ar-AA110hNP

screenshot

image

There are issues in uAssets, but they got declined or closed. See https://github.com/uBlockOrigin/uAssets/issues?q=is%3Aissue+is%3Aclosed+msn

Also see #803

uBlock doesn't support blocking elements within #shadow-root

@Yuki2718
Copy link

Specific or specific-generic cosmetic filters should work for shatow-root.

@gorhill
Copy link
Member

gorhill commented Aug 24, 2022

MSN uses #shadow-root to display recommended articles below an articles

Yes, that is a limitation of the element picker, it can't find elements in a shadow root.

This works on my side:

msn.com##msft-article-card:not(.contentCard)

@ghost
Copy link

ghost commented Aug 24, 2022

I can see this problem in all browsers... (chrome, firefox, edge) but not in Opera

The differences in the logs in main page msn.com/es-es is:

Whit Opera: i can see a lot of cosmetics filters blocked.. see picture
opera

But for example in Chrome or Edge and Firefox NO cosmetics blocked in the logs
chrome

I have reinstalled uBO 10 minutes ago, the same filters lists in Chrome and Opera.
no account logged in edge for example..

@gorhill
Copy link
Member

gorhill commented Aug 24, 2022

NO cosmetics blocked in the logs

It's not possible for uBO to find targeted elements in shadow roots, so it can't report cosmetic filters for which there is a match in a shadow root.

@ghost
Copy link

ghost commented Aug 24, 2022

One date: in Incognito mode no problems for me in all browsers.
this has to be a cookie thing..
I tested: msn.com##+js(cookie-remover) and accept all but the problem still

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
invalid not a uBlock issue unable to reproduce cannot reproduce the issue
Projects
None yet
Development

No branches or pull requests

5 participants