Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Element picker #2252

Closed
8 tasks done
streetwolf opened this issue Sep 10, 2022 · 6 comments
Closed
8 tasks done

Element picker #2252

streetwolf opened this issue Sep 10, 2022 · 6 comments
Labels
invalid not a uBlock issue

Comments

@streetwolf
Copy link

Prerequisites

I tried to reproduce the issue when...

  • uBO is the only extension
  • uBO with default lists/settings
  • using a new, unmodified browser profile

Description

Element picker problem at msn.com

A specific URL where the issue occurs

msn.com

Steps to Reproduce

Go to msn.com
Select element picker
Try to block some element on the page

Expected behavior

Element picker should work as expected.

Actual behavior

The element picker highlights the entire page. Selecting something to block results in the whole page being blocked.

EP works as expected on the latest version of MS Edge.

uBlock Origin version

1.44.2

Browser name and version

Firefox 105.0b9

Operating System and version

Windows 11

@gorhill gorhill added the unable to reproduce cannot reproduce the issue label Sep 10, 2022
@gwarser
Copy link

gwarser commented Sep 10, 2022

Are you sure uBO is enabled on msn? Is cosmetic filtering enabled? Do you have any custom lists (can be caused by incorrectly hidden cookie dialog)?

@streetwolf
Copy link
Author

I did lots of further testing. EP worked fine on a test profile with only uBO as an addon. This fact led to more testing on my normal profile and ultimately I deleted my cookie file and EP started working again. However after a few restarts of Fx the EP problem came back. At some further point in my testing I've been able to have EP working consistently. I noticed that along with the EP problem some elements weren't being blocked. Now they are just like on my test profile.

So it appears my problem is cookie related. I'm still running with a new cookie file and it's possible the problem might come back in time if the 'bad' cookies get saved.

@gorhill
Copy link
Member

gorhill commented Sep 10, 2022

I tried to reproduce the issue when...

...

  • using a new, unmodified browser profile

Then:

I did lots of further testing. EP worked fine on a test profile with only uBO as an addon

Your original description of the issue led us to believe the issue was also present in a new, unmodified browser profile. Pointing out that the issue can't be reproduced in a new, unmodified browser profile helps better narrow the issue and saves time.

@streetwolf
Copy link
Author

I think I found what's causing my problem with EP. I use an addon called Forget Me Not (FMN) a cookie Manager. I've always set the options for cookie deletion for msn.com as Never which means take no action on cookies at this site. When I delete the Never setting for the two URL's that are listed for msn.com PE works fine as well as blocking stuff that wasn't blocked before. You would think telling the addon not to do anything with cookies at msn.com wouldn't cause a problem but it does. Let it be known that I always had the site set to Never and didn't have any problems. Something changed this is the past month or so I would say.

So to test this out install the addon FMN, go to msn.com and click on the FMN icon and you should see two URL's lists. Click on the Create Rule button for each and select Never. The site then should behave incorrectly, we hope. Deleting the Never setting for both URL's should make things work as expected.

Of course your mileage may vary.

@krystian3w krystian3w mentioned this issue Sep 10, 2022
8 tasks
@krystian3w
Copy link

krystian3w commented Sep 10, 2022

🥀 FMN 🥀 = may no survive rewrite to manifest V3 (also have "vacation" to fix bugs e.g. for Firefox). Test with Delete AutoCookie: https://chrome.google.com/webstore/detail/cookie-autodelete/fhcgjolkccmbidfldomjliifgaodjagh

@streetwolf
Copy link
Author

Installed Delete AutoCookie from the Firefox addon site. It's the same version as the one on the Chrome store. If I remember correctly things worked fine out of the box. Once I started fooling around with the greylist and whitelist options I am back with the same problems. I then deleted the expressions for msn.com thinking this would set the site back to an out of the box state but still have the problem.

@gorhill gorhill added invalid not a uBlock issue and removed unable to reproduce cannot reproduce the issue labels Sep 10, 2022
@gorhill gorhill closed this as completed Sep 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
invalid not a uBlock issue
Projects
None yet
Development

No branches or pull requests

4 participants