Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bring back json formatter for bazel 1.1 #4

Merged
merged 1 commit into from
Oct 22, 2019
Merged

Bring back json formatter for bazel 1.1 #4

merged 1 commit into from
Oct 22, 2019

Conversation

burakcoskun
Copy link

No description provided.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@AlessandroPatti AlessandroPatti merged commit 9b3d8f9 into uber-common:uber/ios/1.1.0.001 Oct 22, 2019
AlessandroPatti pushed a commit that referenced this pull request Nov 22, 2019
@burakcoskun
Bring back json formatter for bazel 1.1 (#4)
c30f00e
AlessandroPatti pushed a commit that referenced this pull request Dec 30, 2019
@burakcoskun
Bring back json formatter for bazel 1.1 (#4)
a27a778
AlessandroPatti pushed a commit that referenced this pull request Feb 10, 2020
@burakcoskun
Bring back json formatter for bazel 1.1 (#4)
b9972e0
AlessandroPatti pushed a commit that referenced this pull request Mar 3, 2020
@burakcoskun
Bring back json formatter for bazel 1.1 (#4)
f3416d8
AlessandroPatti pushed a commit that referenced this pull request Apr 15, 2020
@burakcoskun
Bring back json formatter for bazel 1.1 (#4)
de20629
AlessandroPatti pushed a commit that referenced this pull request Apr 15, 2020
@burakcoskun
Bring back json formatter for bazel 1.1 (#4)
64b32cd
AlessandroPatti pushed a commit that referenced this pull request May 28, 2020
@burakcoskun
Bring back json formatter for bazel 1.1 (#4)
28cb257
rmaz pushed a commit that referenced this pull request Jun 30, 2020
@burakcoskun
Bring back json formatter for bazel 1.1 (#4)
b06b4fd
AlessandroPatti pushed a commit to AlessandroPatti/bazel that referenced this pull request Feb 20, 2022
@gregestren @copybara-github
Support select() on constraint_value for aliases.
1c3a245 
This implements approach uber-common#4 of
bazelbuild#13047 (comment).

The basic change adds a new toolchain resolution mode: "resolve iff the target has a select()". It then sets alias() to that mode.

We could remove this special casing if we ever ubiquitously provide platform info to *all* rules (bazelbuild#12899 (comment)).

RELNOTES: alias() can now select() directly on constraint_value()

Fixes bazelbuild#13047.

Closes bazelbuild#14310.

PiperOrigin-RevId: 411868223
chiragramani pushed a commit that referenced this pull request Apr 9, 2022
@brentleyjones @gregestren
Support select() on constraint_value for aliases. (bazelbuild#14754)
0df1851 
This implements approach #4 of
bazelbuild#13047 (comment).

The basic change adds a new toolchain resolution mode: "resolve iff the target has a select()". It then sets alias() to that mode.

We could remove this special casing if we ever ubiquitously provide platform info to *all* rules (bazelbuild#12899 (comment)).

RELNOTES: alias() can now select() directly on constraint_value()

Fixes bazelbuild#13047.

Closes bazelbuild#14310.

PiperOrigin-RevId: 411868223
(cherry picked from commit 1c3a245)

Co-authored-by: Greg Estren <gregestren@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@burakcoskun @CLAassistant @AlessandroPatti