Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Per option #54

Merged
merged 1 commit into from
Jan 3, 2021
Merged

Add Per option #54

merged 1 commit into from
Jan 3, 2021

Conversation

rabbbit
Copy link
Contributor

@rabbbit rabbbit commented Jan 3, 2021

Replaces #21

It seems a bunch of people were interested in the feature (see #21),
it makes sense and it's super easy to add.

We also closed #17 in favour of #21, so it's nice to bring it back.

Replaces #21

It seems a bunch of people were interested in the feature (see #21),
it makes sense and it's super easy to add.
@rabbbit rabbbit requested a review from cinchurge January 3, 2021 02:52
@codecov
Copy link

codecov bot commented Jan 3, 2021

Codecov Report

Merging #54 (3247f7b) into master (11b8621) will increase coverage by 1.74%.
The diff coverage is 83.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #54      +/-   ##
==========================================
+ Coverage   63.33%   65.07%   +1.74%     
==========================================
  Files           3        3              
  Lines          60       63       +3     
==========================================
+ Hits           38       41       +3     
  Misses         22       22              
Impacted Files Coverage Δ
limiter_mutexbased.go 0.00% <0.00%> (ø)
limiter_atomic.go 100.00% <100.00%> (ø)
ratelimit.go 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 11b8621...3247f7b. Read the comment docs.

Copy link

@cinchurge cinchurge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@rabbbit rabbbit merged commit 4fc173c into master Jan 3, 2021
@rabbbit rabbbit deleted the pawel/per branch January 3, 2021 16:39
@rabbbit rabbbit mentioned this pull request Jan 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants