Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a more-explicit NewNop constructor #326

Merged
merged 1 commit into from
Feb 20, 2017
Merged

Add a more-explicit NewNop constructor #326

merged 1 commit into from
Feb 20, 2017

Commits on Feb 19, 2017

  1. Add a more-explicit NewNop Logger constructor 

    `New` already takes a variadic number of options, so we can't also take a
variadic number of cores. Instead, add a niladic `NewNop` constructor that
returns a no-op Logger.

This is already covered by tests, and is also backwards-compatible.
    Akshay Shah committed Feb 19, 2017
    Configuration menu
    Copy the full SHA
    9603204 View commit details
    Browse the repository at this point in the history