[ContractHandler] Handle @Contract with empty value. #450
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The IntelliJ `@Contract` annotation has two fields, `value` and `pure`. When `pure = true`, `value` can be left empty. As such, the following is a valid `@Contract` annotation: ``` @contract( pure = true ) ``` See. https://www.jetbrains.com/help/idea/contract-annotations.html Here, retriving the annotation value produces an empty string. However, existing ContractHandler logic expects `value` to either be `null` or a properly formated string in IntelliJ contract syntax (`"[...] -> [...]; [...]"`). Previous to this change, NullAway would report an error AND crash when seeing the `@Contract` annotation above, rather than ignore it. This patch fixes this.
|
Found while testing #446 , blocker. Will add a test in a moment. |
msridhar
approved these changes
Feb 22, 2021
Pull Request Test Coverage Report for Build #474
💛 - Coveralls |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The IntelliJ
@Contractannotation has two fields,valueand
pure. Whenpure = true,valuecan be left empty.As such, the following is a valid
@Contractannotation:See. https://www.jetbrains.com/help/idea/contract-annotations.html
Here, retriving the annotation value produces an empty
string.
However, existing ContractHandler logic expects
valuetoeither be
nullor a properly formated string inIntelliJ contract syntax (
"[...] -> [...]; [...]").Previous to this change, NullAway would report an error
AND crash when seeing the
@Contractannotation above,rather than ignore it. This patch fixes this.