Add library model for Guava's Closer.register #632
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow up to #628 and our support for
@ParametricNullness
in NullAway 0.9.9.It turns out that
com.google.common.io.Closer
annotates it'sregister
method as:Where the return is only really
@Nullable
if the argument is@Nullable
(it is the same reference).This PR adds a Library Model for this method, which is equivalent to adding the
@Contract("null -> null")
annotation to it.
Note that, in order for this model to be helpful,
AcknowledgeLibraryModelsOfAnnotatedCode
must be set, which would seem to argue for making that the default.